crates/node/build.rs (1)

35-37: Avoid brittle OUT_DIR parsing for build profile.

Line 36 depends on a fixed path shape and can panic unexpectedly. Prefer reading profile directly from build-script env instead of slicing OUT_DIR.

Proposed refactor

-    let out_dir = env::var("OUT_DIR").unwrap();
-    let profile = out_dir.rsplit(std::path::MAIN_SEPARATOR).nth(3).unwrap();
+    let profile = env::var("PROFILE")?;
     println!("cargo:rustc-env=MORPH_BUILD_PROFILE={profile}");

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/node/build.rs` around lines 35 - 37, The current build script parses
OUT_DIR into `profile` using `out_dir.rsplit(...).nth(3)` which is brittle and
can panic; change the logic to read the build profile from the `PROFILE`
environment variable (use `env::var("PROFILE")`) and fall back to a sensible
default if missing, then use that value in the
`println!("cargo:rustc-env=MORPH_BUILD_PROFILE={profile}")` call instead of the
parsed `profile` from `out_dir`; update references to the `out_dir` and
`profile` variables accordingly and remove the fragile rsplit usage.

crates/node/build.rs (2)

40-41: Avoid parsing OUT_DIR to get build profile

Line 41 depends on Cargo path shape and can panic. Prefer PROFILE, which Cargo already provides for build scripts.

Proposed refactor

-    let out_dir = env::var("OUT_DIR").unwrap();
-    let profile = out_dir.rsplit(std::path::MAIN_SEPARATOR).nth(3).unwrap();
+    let profile = env::var("PROFILE")?;
     println!("cargo:rustc-env=MORPH_BUILD_PROFILE={profile}");

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/node/build.rs` around lines 40 - 41, The build script currently
derives the Cargo build profile by parsing OUT_DIR (env::var("OUT_DIR") and the
local variable profile), which relies on Cargo's directory layout and can panic;
change it to read the PROFILE environment variable provided to build scripts
(env::var("PROFILE")) and use that value in place of the parsed profile so you
no longer depend on splitting OUT_DIR; update any uses of the local profile
variable accordingly and handle the Result (e.g., unwrap_or or expect)
consistently.

---

29-39: Use one short-SHA length consistently

Line 29 uses 7 chars, but Line 38 exports 8 chars. This can produce inconsistent metadata across fields.

Proposed cleanup

-    let sha_short = &sha[0..7];
+    let sha_short = &sha[..8];
@@
-    println!("cargo:rustc-env=VERGEN_GIT_SHA_SHORT={}", &sha[..8]);
+    println!("cargo:rustc-env=VERGEN_GIT_SHA_SHORT={sha_short}");

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/node/build.rs` around lines 29 - 39, The code slices the git SHA with
two different lengths (sha_short = &sha[0..7] but prints &sha[..8]), causing
inconsistent metadata; update the logic to compute a single sha_short and reuse
it everywhere (use sha_short for the not_on_tag comparison and for the
VERGEN_GIT_SHA_SHORT export) so both checks/outputs use the identical substring,
and ensure any format! or println! references (e.g., VERGEN_GIT_DESCRIBE check,
MORPH_VERSION_SUFFIX calculation, and VERGEN_GIT_SHA_SHORT export) refer to that
single sha_short symbol.